search

abacritt / angularx-social-login

Social login and authentication module for Angular 17
636 stars 387 forks source link

added text change width and shape of button #575

Closed markarik closed 2 years ago

markarik commented 2 years ago

From this link on Google Button Generator there are attributes from the generated code which would be essential for this package to make it atlist customizable as much as possible

Below is a screenshot of the demo page after working on the attributes

Screenshot (38)

kattoshi commented 2 years ago

I would like to request the following items theme logo_alignmnt locale

markarik commented 2 years ago

For those am still testing on them, once comfortable will push ASAP

markarik commented 2 years ago

@kattoshi Have managed to add themeand logo_alignment
unfortunately on locale have tried testing it but not working on it, Have opted to leave it as from the docs it's written if the locale is left as empty, the button should pick the browsers default locale

Heatmanofurioso commented 2 years ago

@markarik Thanks a lot for your contribution here. Would this be fine to be merged by you? Or would you try to add any more properties to it? The PR looks good by me

kattoshi commented 2 years ago

@markarik Thank you. the test is working fine. image image image

markarik commented 2 years ago

@markarik Thanks a lot for your contribution here. Would this be fine to be merged by you? Or would you try to add any more properties to it? The PR looks good by me

Am humbled,, I think am not in a position to merge it

markarik commented 2 years ago

@markarik Thank you. the test is working fine. image image image

Great thanks ,, I suppose on my laptop it just dint want to work at the moment

Heatmanofurioso commented 2 years ago

@markarik Thanks a lot for your contribution here. Would this be fine to be merged by you? Or would you try to add any more properties to it? The PR looks good by me

Am humbled,, I think am not in a position to merge it

I can merge it. What I meant was to ask if you intended to make any more commits to this PR. Since you've made some changes since it's initial opening

markarik commented 2 years ago

@markarik Thanks a lot for your contribution here. Would this be fine to be merged by you? Or would you try to add any more properties to it? The PR looks good by me

Am humbled,, I think am not in a position to merge it

I can merge it. What I meant was to ask if you intended to make any more commits to this PR. Since you've made some changes since it's initial opening

Yes you can merge it, I don't intend to add anything else