abacritt / angularx-social-login

Social login and authentication module for Angular 17
630 stars 387 forks source link

Google Auth Changes #620

Closed ewwwgiddings closed 1 year ago

ewwwgiddings commented 1 year ago

I recently received an email stating that Google detected using their OAuth 2.0 login with an embedded webview. This is the headline of the email We detected requests to our OAuth 2.0 authorization endpoint from one or more of your OAuth client IDs within an embedded webview context in the past 30 days. What's odd though is I only use this in an Angular app for browser not in an app. It is related to this article: https://developers.googleblog.com/2021/06/upcoming-security-changes-to-googles-oauth-2.0-authorization-endpoint.html Is this something that can or needs to be changed before the deadline? Or does it sound like an issue with something on my end?

Additionally is there any plan to migrate per this document and warning I see in the console: https://developers.google.com/identity/gsi/web/guides/migration

Apologies if this is already fixed. I'm using "angularx-social-login": "^4.1.0", because of my angular version.

aaron-cardenas commented 1 year ago

Same here

ewwwgiddings commented 1 year ago

@aaron-cardenas Do you use Angular Universal at all? I do so was wondering if it was something about that. I've also never seen the warning on the login pop-up that the email says will show up if affected.

signuspl commented 1 year ago

I have the same with version 3.5.7 and Angular 11 and Ionic/Cordova app. Of course I use angularx-social-login only for WEB/PWA version but it is initialized in one of my angular modules. I received same email from Google.

BruneXX commented 1 year ago

Hi Guys, I'm highly interested in this topic, someone has any news about this? Thanks

ewwwgiddings commented 1 year ago

@signuspl My guess for you is that that initialization in the app module is what's causing it for you. Maybe you can test by creating a second client for apps and do it conditionally based on platform?

As for me, I plan to look deeper soon, but my guess is it's the use of Universal?

I find it odd that when I'm on my site I don't see the warning message they said I would for requests that are affected.

cacalo commented 1 year ago

For anyone interested in it, this has been updated on the latests builds. You'll need to update in order for you to get the lastest features.

itsrajverma commented 1 year ago

Hi Guys, someone has any news about this? Thanks

PiyushAgrawal1243 commented 1 year ago

Hi Guys, anyone found any solution , i got the same mail.

@jaibatrik @Heatmanofurioso @Jin-K

PiyushAgrawal1243 commented 1 year ago

I recently received an email stating that Google detected using their OAuth 2.0 login with an embedded webview. This is the headline of the email We detected requests to our OAuth 2.0 authorization endpoint from one or more of your OAuth client IDs within an embedded webview context in the past 30 days. What's odd though is I only use this in an Angular app for browser not in an app. It is related to this article: https://developers.googleblog.com/2021/06/upcoming-security-changes-to-googles-oauth-2.0-authorization-endpoint.html Is this something that can or needs to be changed before the deadline? Or does it sound like an issue with something on my end?

Additionally is there any plan to migrate per this document and warning I see in the console: https://developers.google.com/identity/gsi/web/guides/migration

Apologies if this is already fixed. I'm using "angularx-social-login": "^4.1.0", because of my angular version.

@ewwwgiddings did you get any solution?

cacalo commented 1 year ago

I think it is fixed in the newer versions. Google has been letting everyone know the deprecations is going to happen for some months now. You should consider upgrading your Angular version if you want to keep using Google Oauth.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.