abacritt / angularx-social-login

Social login and authentication module for Angular 17
630 stars 387 forks source link

Wrong imports of rxjs? #628

Closed alesyt0h closed 1 year ago

alesyt0h commented 1 year ago

Hello.

I have an error trying to run ng serve when using this module. It basically says that filter, take, skip can't be imported from RxJS. After some digging I've found thtat google-sigin-button.directive.ts and google-login-provider.ts of this module are importing filter, take and skip from rxjs when it would have to be from rxjs/operators.

I've tried to just update the imports and recompile the module using ng build lib --configuration production to atleast be able to use this package, but that ended up in another error when running the application: image

CmarkoLukas commented 1 year ago

npm install rxjs@latest helps :)

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.