Version 4.1.0 still prints "deprecated" onto console

[aneshodza]

Already tried to talk about it in this issue, but it's closed so I decided to open a new one. The same issue talks about how the deprecation should be fixed in the new version, but I still get the same warning. For everyone in the future: there is a PR which promises to fix it , no idea when or if it will get merged tho

[anuj-scanova]

The angularx-social-login library has been deprecated.

Use @abacritt/angularx-social-login

[aneshodza]

But why does 4.1.0 promise to fix that issue? Am I missing something? And the issue I linked in the original post mentioned something about a fix.

[aneshodza]

More information for anyone coming after me with this issue: the PR to undeprecate it is still open. See here: https://github.com/abacritt/angularx-social-login/pull/598

[LiJell]

@aneshodza version 4.1.0 is not updated yet I guess

[aneshodza]

Yes, sadly it isn't.

[rat-matheson]

The PR is blocked and I don't have permissions to do anything about it. If you are stuck on this issue, you could just get the code from the PR from github (rather than waiting for it to possibly find its way into npm).

[Heatmanofurioso]

I've made a deploy with latest changes but on V12 support https://www.npmjs.com/package/@abacritt/angularx-social-login/v/1.2.4-ngx12.0

Can you test it, please?

[rat-matheson]

I've tested this. Works great! Thanks for much for finishing off the update.

Just a note to anyone switching version, imports need to be changed from angularx-social-login to @abacritt/angularx-social-login

[Heatmanofurioso]

@rat-matheson Closing this. But quick question. We've mentioned the need to change the namespace several times in issues, documentation, npm and other places. Any idea on how to make more people aware of this change? I notice many Issues pop up sometimes due to people not upgrading to the new namespace

[rat-matheson]

Beats me. At some point, people are just going to be upgraded and it will be a non-issue. Previously, I was unable to upgrade due to being stuck on angular 12. The documentation along with the error messages for the most part was sufficient for me. However, note that the examples in the documentation (at least for the new version you just pushed) import from the old package which might throw some people off.

https://www.npmjs.com/package/@abacritt/angularx-social-login/v/1.2.4-ngx12.0

import { SocialLoginModule, SocialAuthServiceConfig } from '@abacritt/angularx-social-login';
import {
  GoogleLoginProvider,
  FacebookLoginProvider
} from 'angularx-social-login';

@NgModule({
...

when it probably should be

import { SocialLoginModule, SocialAuthServiceConfig } from 'angularx-social-login';
import {
  GoogleLoginProvider,
  FacebookLoginProvider
} from 'angularx-social-login';

@NgModule({
...

[Heatmanofurioso]

@rat-matheson Thanks for that notice. I tried to do some quick updates today as soon as possible to try and help the people using it. I'll update those docs tomorrow, and either release a version to NPM to have it updated in there, or just let that change be released in the next change-pr. Thanks