search

abacritt / angularx-social-login

Social login and authentication module for Angular 17
630 stars 388 forks source link

PoC #645 proposal #713

Closed ciekawy closed 8 months ago

ciekawy commented 1 year ago

this is quick and dirty try to apply idea from https://stackoverflow.com/questions/72612704/how-to-get-oauth-token-after-google-one-tap-sign-in-jwt-token-response-of-one-t

with these changes in my case the popup still pops up but just for a moment without interaction so at least it's less annoying

Heatmanofurioso commented 1 year ago

Thanks for your help contributing on this @ciekawy Any chance you can also update the readme on this change?

ciekawy commented 1 year ago

This PR helps a bit in my case but still is not perfect - eg the new window pops up twice (second time just for a few seconds without need for user interaction) so it is still not ideal solution. Also this is not really tested for potential regression nor if this is complete needed change. I needed this for my side project and with limited time unfortunately cannot offer mor at this point. I opened this PR more for reference and asa PoC hoping this can be a base for a more complete update.

stale[bot] commented 9 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.