search

abacritt / angularx-social-login

Social login and authentication module for Angular 17
630 stars 388 forks source link

Incorrect error messages being passed to reject in GoogleLoginProvider.getAccessToken() #746

Open lwestfall opened 6 months ago

lwestfall commented 6 months ago

The error messages in these logical branches should be swapped.

I can PR sometime this week, I'll so be refactoring all error messages as readonly strings a la SocialAuthService.

https://github.com/abacritt/angularx-social-login/blob/7f25ada6d209549be6f15d13d120ebb6070af7a1/projects/lib/src/providers/google-login-provider.ts#L145-L153

Heatmanofurioso commented 6 months ago

@lwestfall Thanks for the dedicated effort here. I've been swamped with work, and haven't been able to do any PRs myself. Looking forward to it if you can