search

abadojack / whatlanggo

Natural language detection library for Go
MIT License
637 stars 64 forks source link

Added confidence rating #15

Closed mmorells closed 5 years ago

mmorells commented 5 years ago

Added the confidence rating with the logic from the original @greyblake package for R. Didn't fix tests completely.

abadojack commented 5 years ago

@mmorells Good work. Could you please make the improvements I suggested

mmorells commented 5 years ago

@abadojack thanks! I made the improvements you suggested. I haven't fixed the tests though, didn't have time to look at them. Not exactly sure what's going on in the tests, and I only made the changes (to the tests) needed to compile.

greyblake commented 5 years ago

Added the confidence rating with the logic from the original @greyblake package for R. Didn't fix tests completely.

The original package is not for R, but Rust :)

mmorells commented 5 years ago

@greyblake Of course, I knew that. My bad