search

abaga129 / sveltekit-adapter-iis

15 stars 5 forks source link

Change dependencies to dev dependencies #10

Closed abaga129 closed 8 months ago

abaga129 commented 9 months ago

@Palkess @KraXen72 I think these dependencies should have been dev dependencies when the project was initially created. Thoughts?

Palkess commented 9 months ago

I think this looks good, none of the deps should be required during production 👍

KraXen72 commented 9 months ago

i don't think they should be in dev-dependencies if they're requried for the runtime though, no? like we import and use functions from fs-extra, if it's not a dependency, won't it get ommited when installing? you could take a look at how adapter-node does it

Palkess commented 9 months ago

I think you're right @KraXen72 , I was probably thinking from the perspective of a repo using this npm package as a devDep. This could always be tested if you want to set up a way to do beta-releases in npm @abaga129 .

abaga129 commented 9 months ago

Hmm yes I see your point. I'll read into it a bit more. It does look like our sveltekit dependency should atleast be a peer dependency.