abaga129 / sveltekit-adapter-iis

15 stars 5 forks source link

Rewrite to use node:http instead of express, and more options #2

Closed KraXen72 closed 10 months ago

KraXen72 commented 10 months ago

Hi, i stumbled upon your adapter for IIS, and while it was a good start, it was not working that well for me. I modified it pretty extensively, adding features i needed. I thought it might be a good idea to contribute them back, since you said contributions are welcome in the readme.

Differences

The biggest switch is from using express to node:http. While they aren't completely the same, it has worked for all my use-cases, and i haven't noticed any differences. My motivation behind the switch is:

Please let me know any requested changes.

abaga129 commented 10 months ago

@KraXen72 Sorry I didnt see your PR sooner. This all looks great. I'm going to look everything over and test it a bit but I dont see any reason not to merge this as it seems to be a major improvement!

KraXen72 commented 10 months ago

thanks for merging! i'll likely contribute some more stuff in the future :3

abaga129 commented 10 months ago

That sounds great! Thank you for this big contribution. I went ahead and squashed the commits into a single commit just to clean up the git history. I hope that's okay. So you will need to updated your fork before making another PR.

I'm glad to see we can work together on IIS support for Sveltekit!

abaga129 commented 10 months ago

Also @KraXen72 I've tagged v1.1.0 so you should be able to install it from the npm registry now

KraXen72 commented 10 months ago

sure, great!