search

abaga129 / sveltekit-adapter-iis

15 stars 5 forks source link

add support for multiple env files #6

Closed KraXen72 closed 10 months ago

KraXen72 commented 10 months ago

the xff, origin etc. env vars can be overwritten by the actual .env files if needed. resolves #5

KraXen72 commented 10 months ago

oh right the feature should be probably documented in the readme as well. something to add later, i guess

KraXen72 commented 10 months ago

please wait with merging before i adjust it to the xml transformation spec

abaga129 commented 10 months ago

@KraXen72 sounds good. I'll wait until you are ready to merge. Adding this feature is a great idea. It's a use case that comes up for me a lot in ASP.net project. I havent had to use this IIS feature yet in Sveltekit but I'm sure I will at some point. Let me know if I can help in anyway!

KraXen72 commented 10 months ago

@abaga129 please take a look

abaga129 commented 10 months ago

@KraXen72 sorry I wasnt able to review it over the weekend. I'll take a look at it today.

abaga129 commented 10 months ago

After looking through it, I think this is a nice change. I actually like the idea of creating it off of env files instead of in the config. If you dont mind finishing that formatting then I'll get it merged! :)

KraXen72 commented 10 months ago

fixed @abaga129