search

abahgat / redmine_didyoumean

A Redmine plugin to search for possible duplicates when users are about to open new issues.
Other
67 stars 46 forks source link

Fuzzy Word Matching #56 #61

Closed swiatkiewicz closed 9 years ago

swiatkiewicz commented 9 years ago

ThinkingSphinx support #56

abahgat commented 9 years ago

Thanks! I will take a look at this over the weekend and hopefully we can integrate it straight away!

rlisowski commented 9 years ago

@abahgat what is the status of this pull request, do you plan to merge it anytime soon?

abahgat commented 9 years ago

@abahgat what is the status of this pull request, do you plan to merge it anytime soon?

Wow, you guys did a great job with this! I'd probably add a couple of lines to the project readme advertising that users can enable this feature and outlining the steps to install the dependencies.

I'd like to test this out on a clean installation, to make sure it is easy to get working, but then I think we can go ahead and merge.

Thanks again

rlisowski commented 9 years ago

@swiatkiewicz fixed all your issues @abahgat, all test are passing on localhost Is something wrong with TravisCI configuration? It's seems it does not use redmine.

abahgat commented 9 years ago

Thanks @korin and @swiatkiewicz, I will take a look at the new code soon.

I am guessing the tests are not using redmine because the branch for this PR does not include 0c8c8b1e625f53c9f227e71f9ef9b09274349860, which instructs Travis on how to pull redmine and use it for tests.

One thing I'd consider for this CL once we get the code to a stable state is to squash it in fewer commits so that the history is easier to follow.

swiatkiewicz commented 9 years ago

Commit's was squashed to one.

swiatkiewicz commented 9 years ago

Hi @abahgat, what about this feature?

abahgat commented 9 years ago

Looks good, I'd like to merge it. I'd still like to figure out why Travis tests fail, though. Part of it must be due to the fact that the we'd need to pre-install sphinx on the host system, I was hoping 912cb97e43257dec90fdb38272af254bd8442958 would fix that, but apparently it did not.

abahgat commented 9 years ago

Hi @swiatkiewicz and @korin, I would really love to merge this feature if we could get the tests to pass. Any chance you know what's causing them to fail?

rlisowski commented 9 years ago

@abahgat tests fixed, commits were squashed

abahgat commented 9 years ago

Looks good! :+1: Thanks for working on this, I might make a few wording changes on the UI and README and send you guys the change for review. Thanks again!