search

abahgat / redmine_didyoumean

A Redmine plugin to search for possible duplicates when users are about to open new issues.
Other
67 stars 46 forks source link

Added delay if event type is keyup #62

Closed edgardmessias closed 9 years ago

abahgat commented 9 years ago

Thanks for taking care of this Edgar, the PR looks good, the only thing I'd ask is to make sure there's always a space before open brackets and braces (( and {) and a space after (} and )), so that the style is consistent.

edgardmessias commented 9 years ago

I'll Work on it already

edgardmessias commented 9 years ago

Ready @abahgat

abahgat commented 9 years ago

Thanks, one more thing you might consider for the future, if you will, is to squash your cleanup and formatting changes with the original commits so that you have a cleaner history for your pull requests.

edgardmessias commented 9 years ago

Thanks, I'll see how it works

abahgat commented 9 years ago

Change has been merged: 3b3684543cd2c1f3ccf69fefcf4c0e90e7dc1380

Thank you again :+1: