Redmine 3.x

[Angelinsky7]

Hi,

I would like to know if you plan to port your awesome plugin to redmine 3.x ?

Thanks

[Androc]

Hello,

I am not the developer but did you try to install it on redmine 3? What was the error?

[Angelinsky7]

Hi, for the plugin to work "correctly" with the sql search (only the only_open_condition tested for now) with ruby 4....

Change the file

redmine_didyoumean/lib/redmine_didyoumean/searching_by_sql.rb

And change the line 33: (the all method dont take params anymore)

#valid_statuses = IssueStatus.all(:conditions => ["is_closed <> ?", true]).collect(&:id)
valid_statuses = IssueStatus.where("is_closed <> ?", true).collect(&:id)

[Androc]

Nice to ear, good job. Why do you put "correctly" in quotes ? Is there something that still does not work after your correction ?

[Angelinsky7]

For what i've tested everything is working fine. but... i've only tested my settings and the way we like this plugin to behave.

So that's why i put "correctly" like that, i'm not sure that it's working for all settings.... (maybe there is other part of the code that use obsolete code.

[Androc]

Ok. Thanks for your feedback. As "didyoumean" seems pretty simple, I think your working case is pretty well the working case of everybody so I suppose your can say that your issue can be safely closed.

[Angelinsky7]

I agree... but isn't it something that some other people could want ?

[Androc]

Oh yes ! Sorry, forget something :) I should have written : "make a pull request to make your solution available for all".

[Angelinsky7]

... no it's me kind of new into git. Thanks for all your help and support

[Androc]

No problem. Do you know how to make a pull request ? Do you need help ?