search

abahgat / redmine_didyoumean

A Redmine plugin to search for possible duplicates when users are about to open new issues.
Other
68 stars 45 forks source link

Call where instead of all #76

Closed Angelinsky7 closed 9 years ago

Angelinsky7 commented 9 years ago

Call the where function instead of the all function because of the ActiveRecord api change. For Redmine 3.x

Androc commented 9 years ago

Ok. So apparently, you know how to make a pull request :) I hope @abahgat will take it in account.

Angelinsky7 commented 9 years ago

Thanks for all your help :-) But i didn't know how... i just learnt (kind of fun) reading the doc. I hope too....

Angelinsky7 commented 9 years ago

I've just see that i am a duplicate of https://github.com/abahgat/redmine_didyoumean/pull/74

Androc commented 9 years ago

You meant "#74 is a duplicate of your #73" ;)

abahgat commented 9 years ago

Hey there, thanks for the pull request! I'd be happy to merge this, but it seems like Travis tests are failing for database backends that are not sqlite are failing: any clue about what's happening?

Angelinsky7 commented 9 years ago

Hi, I can take a look...

abahgat commented 9 years ago

Alright, I'm merging this in: I was hesitant to do so as tests are failing, but the failure doesn't seem to be specific to this request.