abahmed / kwatch

:eyes: monitor & detect crashes in your Kubernetes(K8s) cluster instantly
https://kwatch.dev
MIT License
964 stars 75 forks source link

Helm chart does not output alert config for Telegram #178

Closed drzero42 closed 1 year ago

drzero42 commented 1 year ago

Describe the bug When using the Helm chart with only the Telegram provider for alerts, no alert map is output. This is due to an if-statement that does not check for the telegram map here

To Reproduce Deploy using the Helm chart with this set of values:

kwatch:
  config:
    configTemplate:
      alert:
        telegram:
          token: "${token}"
          chatId: "${chatId}"

The generated ConfigMap will not contain the expected alert section.

Version/Commit Kwatch v0.6.1

eremeevfd commented 1 year ago

@drzero42 could you please check the latest version of chart?

drzero42 commented 1 year ago

@eremeevfd The telegram-values work now, thank you! Unfortunately the newly added clusterName and the disableUpdateCheck values do not make it through the configmap templating in the chart. I'll open another ticket for that! :)