abaisero / asym-rlpo

Asymmetric methods for partially observable reinforcement learning
MIT License
8 stars 2 forks source link

main_a2c.py doesn't run because of missing gym_pomdps module #1

Closed amitfishy closed 2 years ago

amitfishy commented 2 years ago

Hello, thanks for providing code for the paper. I'm able to install all the requirements, but I still get an error while trying to run main_a2c.py

python main_a2c.py

Traceback (most recent call last):
  File "/home/fishy/python_ws/aais-baisero/code/asym-rlpo/main_a2c.py", line 16, in <module>
    from asym_rlpo.algorithms import A2C_ABC, make_a2c_algorithm
  File "/home/fishy/python_ws/aais-baisero/code/asym-rlpo/asym_rlpo/algorithms/__init__.py", line 3, in <module>
    from asym_rlpo.envs import Environment
  File "/home/fishy/python_ws/aais-baisero/code/asym-rlpo/asym_rlpo/envs/__init__.py", line 12, in <module>
    from .env_gym import make_gym_env
  File "/home/fishy/python_ws/aais-baisero/code/asym-rlpo/asym_rlpo/envs/env_gym.py", line 8, in <module>
    import gym_pomdps
ModuleNotFoundError: No module named 'gym_pomdps'

Not sure where to get this module exactly! I'm just trying to reproduce some experiments from your paper: https://arxiv.org/abs/2105.11674

Thanks!

abaisero commented 2 years ago

Hi, thanks for raising this issue to my attention; this code relies on some of my other repositories, but I just noticed that this is not documented anywhere; shortly, I'll update the readme to include this information.

abaisero commented 2 years ago

Hello Amit,

I'm assuming you found the solution to this, since I could not see a github issue on this topic; if you still need help on this, please open a github issue, it makes it a lot easier to track questions, both for me and for future users.

Thanks! Andrea

On Mon, Oct 10, 2022 at 10:56 PM Amit Sinha @.***> wrote:

Thank you, this helps. Could you also please tell me how I could use the environments in ; https://github.com/abaisero/gym-pomdps/tree/master/gym_pomdps/pomdps

I've tried giving the filename as follows: python main_a2c.py heavenhell_3 a2c

But it does not pick up the environment name. Might be nice to have this in the readme too ;)

— Reply to this email directly, view it on GitHub https://github.com/abaisero/asym-rlpo/issues/1#issuecomment-1274023447, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANWG6TEFNMQPEVMBNIDPA3WCTJPHANCNFSM6AAAAAARB2I4MI . You are receiving this because you modified the open/close state.Message ID: @.***>

amitfishy commented 1 year ago

Yes I did! I didn't raise another issue because your corrections were sufficient to get things to work.

Thanks! Amit