search

abakan-zz / ablog

ABlog for blogging with Sphinx
ablog.readthedocs.org
Other
122 stars 35 forks source link

Fix couple of bugs with latest stable Sphinx #93

Closed tadeboro closed 6 years ago

tadeboro commented 7 years ago

Ablog used some deprecated functionality that caused failures when that functionality was actually removed from Sphinx.

This pull request rectifies some of those issues and now it is possible to build project created by start command.

Blendify commented 7 years ago

Poke. Any news on this?

getreu commented 6 years ago

I tested your pull request. It works fine for me. They resolve my issue #92 , #95 . Thank you!

rgrinberg commented 6 years ago

ping. Would be great to have this in :)

rayalan commented 6 years ago

Worked great for fixing both the warnings and env failure on Sphinx v1.6.5 / Py 3.6. Thanks for the fix; would be great to have in a release.

ericholscher commented 6 years ago

Would be great to get this merged. I just blew up building our blog for a while because I had this fork installed locally :)

@abakan let me know if you'd like more contributors for this project! I'd love to make sure ablog continues to work with Sphinx, as it's a wonderful extension.

Blendify commented 6 years ago

Yes! I was going to use this extension but settled on https://pypi.python.org/pypi/sphinxcontrib-newsfeed instead. I would be great to have the extra functionality that this offers.

On Mon, Feb 5, 2018 at 6:29 PM, Eric Holscher notifications@github.com wrote:

Would be great to get this merged. I just blew up building our blog for a while because I had this fork installed locally :)

@abakan https://github.com/abakan let me know if you'd like more contributors for this project! I'd love to make sure ablog continues to work with Sphinx, as it's a wonderful extension.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/abakan/ablog/pull/93#issuecomment-363256907, or mute the thread https://github.com/notifications/unsubscribe-auth/AOeua-rHJdSTFUnntcHvLNWPVPonCiWxks5tR47KgaJpZM4Omzi5 .

-- Aaron Carlisle

Picture taker | Bit cruncher | Pixel pusher | Document writer | Project administrator for the Blender 3D Documentation Project

abakan-zz commented 6 years ago

Hi Folks, I would like to get this merged, but I cannot login to my GitHub account any longer. I had enabled 2FA, but then changed my phone and number :( and never saved backup codes anywhere). It looks like there is no way to regain access for me. Ahmet

On Mon, Feb 5, 2018 at 4:27 PM Aaron Carlisle notifications@github.com wrote:

Yes! I was going to use this extension but settled on https://pypi.python.org/pypi/sphinxcontrib-newsfeed instead. I would be great to have the extra functionality that this offers.

On Mon, Feb 5, 2018 at 6:29 PM, Eric Holscher notifications@github.com wrote:

Would be great to get this merged. I just blew up building our blog for a while because I had this fork installed locally :)

@abakan https://github.com/abakan let me know if you'd like more contributors for this project! I'd love to make sure ablog continues to work with Sphinx, as it's a wonderful extension.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/abakan/ablog/pull/93#issuecomment-363256907, or mute the thread < https://github.com/notifications/unsubscribe-auth/AOeua-rHJdSTFUnntcHvLNWPVPonCiWxks5tR47KgaJpZM4Omzi5

.

-- Aaron Carlisle

Picture taker | Bit cruncher | Pixel pusher | Document writer | Project administrator for the Blender 3D Documentation Project

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/abakan/ablog/pull/93#issuecomment-363268006, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMWGRysdYAwbjjnrYJdJ3IVk0daQU5Gks5tR5x5gaJpZM4Omzi5 .

abakan-zz commented 6 years ago

Folks, I also have been planning to ask someone to take the ownership of this project for good. I can add that person as a maintainer/owner of the project to PyPI and ReadTheDocs.org. Would anyone care to do so?

On Mon, Feb 5, 2018 at 9:45 PM Ahmet Bakan lordnapi@gmail.com wrote:

Hi Folks, I would like to get this merged, but I cannot login to my GitHub account any longer. I had enabled 2FA, but then changed my phone and number :( and never saved backup codes anywhere). It looks like there is no way to regain access for me. Ahmet

On Mon, Feb 5, 2018 at 4:27 PM Aaron Carlisle notifications@github.com wrote:

Yes! I was going to use this extension but settled on https://pypi.python.org/pypi/sphinxcontrib-newsfeed instead. I would be great to have the extra functionality that this offers.

On Mon, Feb 5, 2018 at 6:29 PM, Eric Holscher notifications@github.com wrote:

Would be great to get this merged. I just blew up building our blog for a while because I had this fork installed locally :)

@abakan https://github.com/abakan let me know if you'd like more contributors for this project! I'd love to make sure ablog continues to work with Sphinx, as it's a wonderful extension.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/abakan/ablog/pull/93#issuecomment-363256907, or mute the thread < https://github.com/notifications/unsubscribe-auth/AOeua-rHJdSTFUnntcHvLNWPVPonCiWxks5tR47KgaJpZM4Omzi5

.

-- Aaron Carlisle

Picture taker | Bit cruncher | Pixel pusher | Document writer | Project administrator for the Blender 3D Documentation Project

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/abakan/ablog/pull/93#issuecomment-363268006, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMWGRysdYAwbjjnrYJdJ3IVk0daQU5Gks5tR5x5gaJpZM4Omzi5 .

nabobalis commented 6 years ago

@abakan If no one else wants to, I am happy to do so. We use this for a org website (sunpy) and we have been talking about taking it under that org so we can maintain it.

getreu commented 6 years ago

@nabobalis Thank you!

abakan-zz commented 6 years ago

Nabil, That would be great! ABlog will be in very good hands :) How can we proceed? I cannot change ownership of the github project, so I guess you could fork it or create a new project under your org with latest patches applied. Either option is perfectly fine with me. Do you have ReadTheDocs and PyPI accounts that I can add as owners of the project therein? Ahmet

On Thu, Feb 8, 2018 at 2:00 AM Jens Getreu notifications@github.com wrote:

@nabobalis https://github.com/nabobalis Thank you!

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/abakan/ablog/pull/93#issuecomment-364061392, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMWGfldey9-Z_zJnlbQKWk7XxHVrWmBks5tSsXEgaJpZM4Omzi5 .

nabobalis commented 6 years ago

PyPI: Nabobalis RTD: nabobais (I missed spelt it without noticing and never created a new account for it).

We have a fork and I will make sure that the project has all current PRs merged in and once that is ready and I setup travis, I will release an updated version hopefully within a week.

abakan-zz commented 6 years ago

Nabi, I have added you in both PyPI and RTD. I appreciate you agreeing to maintain it!

On Thu, Feb 8, 2018 at 1:02 PM Nabil Freij notifications@github.com wrote:

PyPI: Nabobalis RTD: Nabobais (I missed spelt it without noticing and never created a new account for it).

We have a fork and I will make sure that the project has all current PRs merged in and once that is ready and I setup travis, I will release an updated version hopefully within a week.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/abakan/ablog/pull/93#issuecomment-364247280, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMWGVm3eGhQRQUkBfC6Bq_Lr0vNLb36ks5tS2DygaJpZM4Omzi5 .

ericholscher commented 6 years ago

@abakan Have you reached out to GitHub? If you have access to the account email, their support might be able to help you.

abakan-zz commented 6 years ago

Eric, I just contacted them, and learned that they can't help me with recovering account in this case. I don't have the phone with the authenticator app, the backup phone number, or the backup codes that I had downloaded long time ago. They offered unlinking my email from that account, so that I can create a new account using the same email address :/

On Thu, Feb 8, 2018 at 8:10 PM Eric Holscher notifications@github.com wrote:

@abakan https://github.com/abakan Have you reached out to GitHub? If you have access to the account email, their support might be able to help you.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/abakan/ablog/pull/93#issuecomment-364329843, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMWGelyNyB61aF9vsQOaQflCuSR9kA2ks5tS8UigaJpZM4Omzi5 .

nabobalis commented 6 years ago

So we have https://github.com/sunpy/ablog now and I am in the process of setting up the CI and other items to get ready for a new release. I have merged all the open PRs into master on that repo.

I need to create an issue saying that development has moved to the new repo.

nabobalis commented 6 years ago

This has now been merged into here. Thank you for the PR!

ericholscher commented 6 years ago

Also note, this isn't my extension! It's miscredited to me here: https://github.com/sunpy/ablog/blob/master/README.rst :)

nabobalis commented 6 years ago

That's what happens when I have too many open repo tabs.