search

abakh / nbsdgames

A package of 18 text-based modern games
Other
208 stars 16 forks source link

How do package maintainers find out about new versions? #26

Closed abakh closed 2 years ago

abakh commented 2 years ago

Hi @carlocab, it seems it was you who updated the homebrew nbsdgames bottle for version 4.1.2, thank you for that.

I was wondering how did packaging people find about version 4.1.2 without me announcing it anywhere other than in the releases page? Also how they didn't find about the new version? Perhaps either I or Github changed a thing.

carlocab commented 2 years ago

We usually use brew livecheck to find new versions. We have some automation that automatically updates some formulae. For many others, we rely on pull requests from contributors. Many of these contributors also use brew livecheck, which does know about a new version:

❯ brew livecheck nbsdgames
nbsdgames : 4.1.2 ==> 5

There was an attempt to update nbsdgames at Homebrew/homebrew-core#94416, but that was not merged because CI failed.

Pull requests to update the formula welcome. You can use this action to automate version updates going forward, but that relies on CI on the pull request succeeding, of course.

abakh commented 2 years ago

@carlocab Thanks for the info, it seems the problem was that the test wanted "sudoku 1" output to be "2 <= size <= 7" (why would it test for that?) but now it is "sudoku -s 1" that does the same thing.

carlocab commented 2 years ago

I don't know why it tests for that -- that was the test that was added when the formula was created in https://github.com/Homebrew/homebrew-core/pull/81252.

abakh commented 2 years ago

@carlocab Where do I change the test? Or could you? Since it is a 2 char change and you probably have access to the repo.

It is just "sudoku 1" ==> "sudoku -s 1"

carlocab commented 2 years ago

The formula is updated by opening a pull request just like https://github.com/Homebrew/homebrew-core/pull/94416. Our master branch is protected, so the only way to make changes to it is via pull request. I can have a look at some point about opening a pull request if you'd rather not.

abakh commented 2 years ago

@carlocab It would be nice if you do. I am not familiar with homebrew. Thanks in advance.