abalabahaha / zlib-sync

Synchronous zlib for NodeJS
MIT License
35 stars 7 forks source link

Node 22 support #12

Open SammyWhamy opened 5 months ago

SammyWhamy commented 5 months ago

Currently can't install on Node 22 Node 22 has just been released, so no rush. Just wanted to report it as I ran into it myself

Error log ``` C:\Users\usr\AppData\Local\node-gyp\Cache\22.0.0\include\node\v8-function-callback.h(408,62): warning C4003: not enough arguments for function-like macro invocation 'min' [C:\proj\node_modules\.pnpm\zlib-sync@0.1.9\node_modules\zlib-sync\bui… (compiling source file '../src/zlib_sync.cc') C:\Users\usr\AppData\Local\node-gyp\Cache\22.0.0\include\node\v8-function-callback.h(409,62): warning C4003: not enough arguments for function-like macro invocation 'max' [C:\proj\node_modules\.pnpm\zlib-sync@0.1.9\node_modules\zlib-sync\bui… (compiling source file '../src/zlib_sync.cc') C:\Users\usr\AppData\Local\node-gyp\Cache\22.0.0\include\node\v8-function-callback.h(408,62): error C2589: '(': illegal token on right side of '::' [C:\proj\node_modules\.pnpm\zlib-sync@0.1.9\node_modules\zlib-sync\build\zlib_sync.vcxproj] (compiling source file '../src/zlib_sync.cc') C:\Users\usr\AppData\Local\node-gyp\Cache\22.0.0\include\node\v8-function-callback.h(408,62): error C2760: syntax error: ')' was unexpected here; expected 'expression' [C:\proj\node_modules\.pnpm\zlib-sync@0.1.9\node_modules\zlib-sync\build\… (compiling source file '../src/zlib_sync.cc') C:\Users\usr\AppData\Local\node-gyp\Cache\22.0.0\include\node\v8-function-callback.h(408,62): error C2760: syntax error: ')' was unexpected here; expected ';' [C:\proj\node_modules\.pnpm\zlib-sync@0.1.9\node_modules\zlib-sync\build\zlib_sync… (compiling source file '../src/zlib_sync.cc') C:\Users\usr\AppData\Local\node-gyp\Cache\22.0.0\include\node\v8-function-callback.h(408,62): error C3878: syntax error: unexpected token ')' following 'expression_statement' [C:\proj\node_modules\.pnpm\zlib-sync@0.1.9\node_modules\zlib-sync… (compiling source file '../src/zlib_sync.cc') C:\Users\usr\AppData\Local\node-gyp\Cache\22.0.0\include\node\v8-function-callback.h(408,62): message : error recovery skipped: ') <' [C:\proj\node_modules\.pnpm\zlib-sync@0.1.9\node_modules\zlib-sync\build\zlib_sync.vcxproj] (compiling source file '../src/zlib_sync.cc') C:\Users\usr\AppData\Local\node-gyp\Cache\22.0.0\include\node\v8-function-callback.h(408,62): message : error recovery skipped: ') ) ?' [C:\proj\node_modules\.pnpm\zlib-sync@0.1.9\node_modules\zlib-sync\build\zlib_sync.vcxproj] (compiling source file '../src/zlib_sync.cc') C:\Users\usr\AppData\Local\node-gyp\Cache\22.0.0\include\node\v8-function-callback.h(408,62): message : error recovery skipped: ') :' [C:\proj\node_modules\.pnpm\zlib-sync@0.1.9\node_modules\zlib-sync\build\zlib_sync.vcxproj] (compiling source file '../src/zlib_sync.cc') C:\Users\usr\AppData\Local\node-gyp\Cache\22.0.0\include\node\v8-function-callback.h(408,62): message : error recovery skipped: ') ) ) . . . )' [C:\proj\node_modules\.pnpm\zlib-sync@0.1.9\node_modules\zlib-sync\build\zlib_sync.vcxproj] (compiling source file '../src/zlib_sync.cc') C:\Users\usr\AppData\Local\node-gyp\Cache\22.0.0\include\node\v8-function-callback.h(409,62): error C2589: '(': illegal token on right side of '::' [C:\proj\node_modules\.pnpm\zlib-sync@0.1.9\node_modules\zlib-sync\build\zlib_sync.vcxproj] (compiling source file '../src/zlib_sync.cc') C:\Users\usr\AppData\Local\node-gyp\Cache\22.0.0\include\node\v8-function-callback.h(409,62): error C2760: syntax error: ')' was unexpected here; expected 'expression' [C:\proj\node_modules\.pnpm\zlib-sync@0.1.9\node_modules\zlib-sync\build\… (compiling source file '../src/zlib_sync.cc') C:\Users\usr\AppData\Local\node-gyp\Cache\22.0.0\include\node\v8-function-callback.h(409,62): error C2760: syntax error: ')' was unexpected here; expected ';' [C:\proj\node_modules\.pnpm\zlib-sync@0.1.9\node_modules\zlib-sync\build\zlib_sync… (compiling source file '../src/zlib_sync.cc') C:\Users\usr\AppData\Local\node-gyp\Cache\22.0.0\include\node\v8-function-callback.h(409,62): error C3878: syntax error: unexpected token ')' following 'expression_statement' [C:\proj\node_modules\.pnpm\zlib-sync@0.1.9\node_modules\zlib-sync… (compiling source file '../src/zlib_sync.cc') C:\Users\usr\AppData\Local\node-gyp\Cache\22.0.0\include\node\v8-function-callback.h(409,62): message : error recovery skipped: ') >' [C:\proj\node_modules\.pnpm\zlib-sync@0.1.9\node_modules\zlib-sync\build\zlib_sync.vcxproj] (compiling source file '../src/zlib_sync.cc') C:\Users\usr\AppData\Local\node-gyp\Cache\22.0.0\include\node\v8-function-callback.h(409,62): message : error recovery skipped: ') ) ?' [C:\proj\node_modules\.pnpm\zlib-sync@0.1.9\node_modules\zlib-sync\build\zlib_sync.vcxproj] (compiling source file '../src/zlib_sync.cc') C:\Users\usr\AppData\Local\node-gyp\Cache\22.0.0\include\node\v8-function-callback.h(409,62): message : error recovery skipped: ') :' [C:\proj\node_modules\.pnpm\zlib-sync@0.1.9\node_modules\zlib-sync\build\zlib_sync.vcxproj] (compiling source file '../src/zlib_sync.cc') C:\Users\usr\AppData\Local\node-gyp\Cache\22.0.0\include\node\v8-function-callback.h(409,62): message : error recovery skipped: ') ) ) . . . )' [C:\proj\node_modules\.pnpm\zlib-sync@0.1.9\node_modules\zlib-sync\build\zlib_sync.vcxproj] (compiling source file '../src/zlib_sync.cc') ```
JMTK commented 5 months ago

Looks like this would require more updates than previously where we could just update the nan package.