search

abalabahaha / zlib-sync

Synchronous zlib for NodeJS
MIT License
35 stars 7 forks source link

update calls to use contexts and convert Maybes into Checked values, … #3

Closed churchofthought closed 4 years ago

churchofthought commented 5 years ago

…for compatibility with node 12.6.0 and v8 >= 7.5.288.22

churchofthought commented 4 years ago

You're welcome. Thanks for making this package! Sorry for the late reply. I have been busy working on a cancellable tasks async addon for ES2019. I will make the requested changes and push a new pull request. Is that still something you'd still like me to do? I'm only asking because I don't know if you have already made the changes yourself. Cheers

abalabahaha commented 4 years ago

Go ahead. Just commit to the branch, no need to make a new PR

abalabahaha commented 4 years ago

Though, if this is going to take another 8 days, I'll just make the changes here.