search

abalabahaha / zlib-sync

Synchronous zlib for NodeJS
MIT License
35 stars 7 forks source link

Bump nan from 2.14.0 to 2.17.0 #9

Closed JMTK closed 1 year ago

JMTK commented 1 year ago

The postbuild script to rebuild those packages when installing discord.js (on Node 19 for me) with:

../../nan/nan_callbacks.h:55:23: error: ‘AccessorSignature’ is not a member of ‘v8’
   55 | typedef v8::Local<v8::AccessorSignature> Sig;
      |                       ^~~~~~~~~~~~~~~~~
../../nan/nan_callbacks.h:55:40: error: template argument 1 is invalid
   55 | typedef v8::Local<v8::AccessorSignature> Sig;
      |

Changelog: https://github.com/nodejs/nan/compare/v2.16.0...v2.17.0

yarn why nan showed that those packages prefer the older versions, simply adding to my package.json

"resolutions": {
    "nan": "2.17.0"
},

fixes the issue. Not sure if there's anything better I could do

ghost commented 1 year ago

Can confirm this fix works for me.

ghost commented 1 year ago

Also relevant:

abalabahaha commented 1 year ago

Sorry this got lost in my inbox, thanks