search

abalakh / airgun

Airgun moved to https://github.com/SatelliteQE/airgun
https://github.com/SatelliteQE/airgun
1 stars 2 forks source link

Add self.prerequisite_view for step() #9

Closed mfalesni closed 6 years ago

oshtaier commented 6 years ago

self.parent sounds better, but if we need to have that try...except block - let's keep it

oshtaier commented 6 years ago

btw, we following pep8, so long names are not good

mfalesni commented 6 years ago

self.parent is not always set by the default implementation. We follow PEP8 as well, but this was the best we could come up with :)

abalakh commented 6 years ago

@mfalesni why not set self.parent then? Similar to your proposal:

if not hasattr(self, 'parent'):
    setattr(self, 'parent', None)
mfalesni commented 6 years ago

Actually, we should not need it since you assume the prerequisite always defines some view. So this PR is purely for the name, therefore can be probably closed.

mfalesni commented 6 years ago

As per irc discussion