abaldwin88 / roamer

The Plain Text File Manager
MIT License
606 stars 15 forks source link

vidir can edit a piped in list of files #17

Open purpleidea opened 7 years ago

purpleidea commented 7 years ago

Bug Report Template

roamer version:

OS:

Python version:

Steps to reproduce (start with removing ~/.roamer-data):

abaldwin88 commented 7 years ago

vidir doesn't allow you to cut/copy/paste files. It does however allow you to edit a list of files inside subdirectories which I think is pretty nifty. I'm planning to implement that here in #11 .

Until #11 is completed I am leaving this issue open. I am renaming the title so that if people are looking for that particular feature they'll know where to find it.

purpleidea commented 7 years ago

As you like. Just wanted to give you the heads up. Maybe it might be more sane to add the "copying" feature to vidir instead. The numbered lines is more sane than the hashes at the end imo.

Cheers

On Wed, Aug 30, 2017 at 8:45 AM, Alex Baldwin notifications@github.com wrote:

vidir doesn't allow you to cut/copy/paste files. It does however allow you to edit a list of files inside subdirectories which I think is pretty nifty. I'm planning to implement that in here in #11 https://github.com/abaldwin88/roamer/issues/11 .

Until #11 https://github.com/abaldwin88/roamer/issues/11 is completed I am leaving this issue open. I am renaming the title so that if people are looking for that particular feature they'll know where to find it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/abaldwin88/roamer/issues/17#issuecomment-325978921, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIPs3ruP9a6E7vRAj_iVrkkjqahD6XPks5sdVl3gaJpZM4PHAZX .

abaldwin88 commented 7 years ago

Cheers 🍻

~I don't believe "copying" would work cleanly with a line number approach. Wouldn't be able to handle the corner cases.~

EDIT: I did find an updated vidir that implemented a copying feature within the same instance. It's well implemented and kudos to the author for how they used temporary files. https://github.com/trapd00r/vidir

Having said that I do like the option in roamer to copy between multiple sessions which simply will not be possible with a line number approach. Looking to the future a hash based approach should allow us to implement features like --undo or organizing a persisted directory file.

From a developer perspective hashing adds complexity but as a user I like having minified access to file path/versions.