search

abandonware / node-bluetooth-hci-socket

MIT License
42 stars 47 forks source link

Connect / Disconnect workaround #32

Closed splitice closed 2 years ago

splitice commented 2 years ago

Not ready to merge

Also includes a build command npm run build for QoL during development

splitice commented 2 years ago

Relates to #31

splitice commented 2 years ago

Up to this point the patch is minor and largely deals with handling edge cases (i.e socket errors)

rzr commented 2 years ago

Please rebase and update PR title if ready to be merged

splitice commented 2 years ago

Today this PR can be considered complete as far as Noble compatibility (I put it through it's paces)

I don't have any bleno knowledge, if someone wants to test it for bleno feel free to submit results

rzr commented 2 years ago

tests feedback welcome

rzr commented 2 years ago

please preserve other files and open other PR and explain why they should be removed

rzr commented 2 years ago

may you squash changes ?

splitice commented 2 years ago

@rzr I didnt realize I didnt pr as as a feature branch (my bad). This next set of commits is experimental (tried to fix npm 7 and some issues with late version npm 6). I'll squash / remove before this is likely to merge.

rzr commented 2 years ago

it's not a problem, this way you can check CI results, a way to make it it clear it's a WIP is to set PR to draft to make sure it won't be merged until ready.

rzr commented 2 years ago

I think change set is good to be rebased , squashed and then merged ?

splitice commented 2 years ago

@rzr I'll fix this pr so that it ends at 94e1a2607e54b454314d308e64818d79ab19c008 for you this week.

splitice commented 2 years ago

Superceeded by #33