search

abandonware / node-bluetooth-hci-socket

MIT License
42 stars 47 forks source link

Connect / Disconnect workaround #33

Closed splitice closed 2 years ago

splitice commented 2 years ago

This is a re-submission of PR #32

rzr commented 2 years ago

Please rebase and double check the appveyor or open an issue to track this bot which can be disabled in next change

rzr commented 2 years ago

is this easy to fix ? :

https://ci.appveyor.com/project/rzr/node-bluetooth-hci-socket/builds/41824764

splitice commented 2 years ago

@rzr yes, drop support for node 10 (it's out of support anyway).

FYI I'm working on a complete overhaul of this workaround to resolve memory leaks present in both this version and the original (they leak the l2cap sockets).

My first attempt wasnt successful as it breaks on certain BT implementations (e.g Broadcom) that output reconnections as:

  1. Connect Device 1 (handle 1)
  2. Connect Device 1 (handle 2)
  3. Disconnect Device 1 (handle 1)

A re-engineering of the workaround is required to handle cases like this

splitice commented 2 years ago

34