search

abandonware / node-bluetooth-hci-socket

MIT License
42 stars 47 forks source link

Rebuild not possible #38

Closed Apollon77 closed 2 years ago

Apollon77 commented 2 years ago

I did some nodejs upgrade tests and had bigger issues getting bluetooth-hci-socket rebuilded because by default it simply told

[@abandonware/bluetooth-hci-socket] Success: "/opt/iobroker/node_modules/@abandonware/bluetooth-hci-socket/lib/binding/bluetooth_hci_socket.node" already installed Pass --update-binary to reinstall or --build-from-source to recompile

I tried many things and did a bigger research. There is no way to add more parameters to the "nom rebuild" command, so in the end "npm i" would be the only option (with other side effects).

In fact I ended up in adding "--update-binary" to the "install script" and with this a rebuild was successful too ...

Apollon77 commented 2 years ago

@rzr would you also mind releasing it?

rzr commented 2 years ago

you can do it too see history and submit a Release commit it will be released

Apollon77 commented 2 years ago

Yes you're right ... forgot that :-))

Apollon77 commented 2 years ago

@rzr If I would do it I would also upgrade the package-locj file because my dev system is already on npm 8 ... ok? Or would it be an option that you bump it?

Apollon77 commented 2 years ago

@rzr Any advice?

rzr commented 2 years ago

npm install --global npm-check-updates

Apollon77 commented 2 years ago

@rzr it is not about finding updateable deps ... it i about the lock file and the version ... I can do the release PR but then it will have an updated lock file version (alnd also the abve script will not change that). is this acceptable?

Apollon77 commented 1 year ago

@rzr sorry to bother you again ... if it is ok that I update package lock to npm 8 then I can do the PR ... what's your opinion?

rzr commented 1 year ago

yea sure try it , and look at history to create a PR to make a new release !