abandonware / node-bluetooth-hci-socket

MIT License
42 stars 47 forks source link

Release 0.5.3-9 #44

Closed AlCalzone closed 1 year ago

Apollon77 commented 1 year ago

@rzr relates to https://github.com/abandonware/node-bluetooth-hci-socket/issues/38 to release it.

PR comes from a collegue because I can not even build package-lock because working on a mac :-)

Please approve

Apollon77 commented 1 year ago

So, now we would ideally need the same for noble, right? :-) ... tp have a new version that forces to get the update to the users

rzr commented 1 year ago

humm not that easy we need to check what went wrong with:

https://github.com/abandonware/node-bluetooth-hci-socket/actions/runs/3711237998/jobs/6291451658#step:5:11

fatal: detected dubious ownership in repository at '/github/workspace'

Related-to: https://github.com/actions/checkout/issues/766

Update: Problem resolved , with:

https://github.com/abandonware/node-bluetooth-hci-socket/commit/bd0ce3cf2bf2977069a4611025a4d8668cf1f2d4

Versions will need to be pinned once verified too

BTW: Enjoy:

https://www.npmjs.com/package/@abandonware/noble/v/1.9.2-17

Apollon77 commented 1 year ago

@rzr Thank you , but I think the nobile one was not correct, see https://github.com/abandonware/noble/commit/29166df77354275801b5018e9dd5553d258acef5#r93296429

rzr commented 1 year ago

yes I wanted to check the publish process feel free to bump it too see: https://github.com/abandonware/noble/commit/29166df77354275801b5018e9dd5553d258acef5#commitcomment-93394730