search

abandonware / node-bluetooth-hci-socket

MIT License
42 stars 47 forks source link

Make sure to only have one cleanup interval #45

Closed Apollon77 closed 1 year ago

Apollon77 commented 1 year ago

@rzr @splitice Please review

rzr commented 1 year ago

lgtm , i am wondering if the"if" is needed here too

Apollon77 commented 1 year ago

formally on first call of start there is no timer set ... Yes clearInterval should silently ignore when called with an "invalid value" but I personally think thats bad code style :-)

splitice commented 1 year ago

Makes sense to me.

We moved away from Bluetooth hci socket for a fork of node raw socket btw. We already maintained a fork of that project for other components and it made sense for us.

Only compatible with Linux user channel mode (which in our experience is more reliable anyway)

Apollon77 commented 1 year ago

@splitice What are the benefits of the node raw socket? If it is "better" then why not also integrating it into the noble fork from here as alternative or such?