search

abandonware / node-bluetooth-hci-socket

MIT License
42 stars 47 forks source link

Node 12 compatibility #5

Closed akx closed 4 years ago

akx commented 5 years ago

This PR adds compatibility for the Node 12.x series, as required for my downstream project Ruuvidriver: https://github.com/akx/ruuvidriver/pull/3

rzr commented 5 years ago

Thanks please also forward patch upstream and crosslink URL

akx commented 5 years ago

Thanks please also forward patch upstream and crosslink URL

Do you mean backporting this patch onto upstream master, or just opening an issue attempting to notify upstream about these changes?

rzr commented 5 years ago

Opening the issue is a good start and should be enough, then It will be appreciated that you also comment the pending PRs, and eventually pick and port them to @abandonware fork if relevent, then I will release a new version, does this sound like a good plan?

akx commented 5 years ago

Alright, I opened https://github.com/noble/node-bluetooth-hci-socket/issues/114 in the upstream repo. Re the other PRs in upstream, I can maybe take a look, sure. :)

janhaa commented 4 years ago

Can I help you with this somehow? Want to use latest node version, but this issue is preventing it.

mrstegeman commented 4 years ago

@rzr Can you do a new release?

rzr commented 4 years ago

I can try as soon I get a better connectivity

rzr commented 4 years ago

https://www.npmjs.com/package/@abandonware/bluetooth-hci-socket/v/0.5.3-3 release

Btw please angine fix appvendor then i will use Travis to publish on pushed tag