search

abandonware / node-bluetooth-hci-socket

MIT License
42 stars 47 forks source link

add support for enchanced connection #50

Closed kele6ra closed 6 months ago

kele6ra commented 11 months ago

Added capability of enhanced connection from extended features of ble5

Apollon77 commented 11 months ago

@kele6ra DO you maybe have alink to the relevant specs?

kele6ra commented 11 months ago

@kele6ra DO you maybe have alink to the relevant specs?

Hello, yes https://www.bluetooth.org/DocMan/handlers/DownloadDoc.ashx?doc_id=521059 7.8.66 LE Extended Create Connection command 7.7.65.10 LE Enhanced Connection Complete event There were issue with extended connection in noble and I understand that there is a handler in socket library. I made commands equals to the bluez stack and checked them from specification. I have checked it with usb-hci dongle with Zephyr RTOS.

kele6ra commented 11 months ago

hi , it would be nice to have all cleanup/style changes in a separate commit

Hello, yes. I will remove style changes, sorry for it. I forget that setup styler for vsc before.

Apollon77 commented 11 months ago

@kele6ra Fine to include the style changes ... just in a separate commit so that it can be reviewed easier

kele6ra commented 11 months ago

@kele6ra Fine to include the style changes ... just in a separate commit so that it can be reviewed easier

add style changes for cpp and h files

kele6ra commented 11 months ago

Extra check welcome , note you could have more cleanup in 2d patch feel free to improve , or we can merge it that way

I have checked it during implementation (ubnutu 20) with some sensors with CodedPHY and my colleagues are checking it now I will notify if we will find something

Apollon77 commented 11 months ago

I plan to review against specs next days ... also to get a bit into that specs topic ... but if it works this is probably saying more. :-)