search

abandonware / node-bluetooth-hci-socket

MIT License
42 stars 47 forks source link

Prevent build upgrades and test Node.js 20 #53

Closed Apollon77 closed 5 months ago

Apollon77 commented 9 months ago

Hey, we need to update thios (and most likely also the other packages afterwards). Python 3.12 breaks all older node-gy versions and so many issdues because these older versions are in npm bundled.

Only option I found is this.

@rzr Please review and lets merge this. We could bring it out as last line of the old verschioning schema, but in fcat we limit now nodejs 10+. WDYT?

Apollon77 commented 6 months ago

@rzr what about this long hanging PR? ...

rzr commented 6 months ago

Please rebase

Apollon77 commented 6 months ago

done

rzr commented 5 months ago

hi, I see a merge commit and "This branch cannot be rebased due to conflicts" can you try to rebase again ?

Apollon77 commented 5 months ago

SImply Sqash and merge please

rzr commented 5 months ago

I am afraid I can't because of conflicts : "This branch cannot be rebased due to conflicts"

you have to rebase your branch, if you can't I'll drop this PR and do the work my side

rzr commented 5 months ago

I've rebased it and released thanks anyway

https://github.com/abandonware/node-bluetooth-hci-socket/commit/d82e19c6f9fa1df6e18cce12367476d606581eab