abantecart / abantecart-src

AbanteCart is a free PHP based eCommerce solution for merchants to provide ability creating online business and sell products online quick and efficient. AbanteCart application is built and supported by experienced enthusiasts that are passionate about their work and contribution to rapidly evolving eCommerce industry. AbanteCart is more than just a shopping cart, it is rapidly growing eCommerce platform
www.abantecart.com
Open Software License 3.0
142 stars 161 forks source link

ci: add minimium MariaDB/MySQL versions #1691

Closed grooverdan closed 6 months ago

grooverdan commented 6 months ago

I see by your updated page you've listed minimum database versions

https://www.abantecart.com/ecommerce-getting-started

With a minimum listed it seem worth testing those.

MariaDB never had an 8 version, so I've used 10.5 (as the 10.4 version is almost out of maintenance - https://mariadb.org/about/#maintenance-policy) that has another full year of long term support.

Matching your MySQL descriptions I've used 5.7 and the latest (currently 8.4 - https://hub.docker.com/_/mysql).

The note "MySQL 8 requires PHP 7.4 or higher" looks odd as 8.0 is listed as the minimum PHP version.

I did try to do something more minimal as far the number of jobs but ran into a github action limitation - https://github.com/actions/runner/issues/3279.

PHP 8.0 could be added easily but it grows to 16 jobs.

Thanks for your support. I'll stop tinkering now so you can focus on UI and functional things.

BasaraABC commented 6 months ago

We always welcome contributions and suggestions like yours that help improve our project. Please feel free to continue sharing your contributions and feedback in the future.