search

abap2UI5-apps / abap-sql-console

Quickly Run SQL Commands in Your Browser
MIT License
10 stars 6 forks source link

gread idea ! ztoad #2

Closed choper725 closed 6 months ago

choper725 commented 7 months ago

started working on using the logic from https://github.com/marianfoo/ztoad

to this class..

ill add logic for old releases syntax such as select without FIELDS keyword.

ill pr when im done.

oblomov-dev commented 7 months ago

thank you for the PR! 🙏

fyi, i separated your logic into an extra class now. maybe in the future there is the chance to develop a similar logic for ABAP Cloud Language. Also did some refactoring, i hope it breaks nothing but my tests are fine.

choper725 commented 7 months ago

im not working on cloud system, does the on prem is working on cloud. ?

oblomov-dev commented 7 months ago

no it uses perform and macros, thats why it does not work in abap cloud. but no problem! i separated it to an extra class which gives us the possibility to add another class for cloud in the future.