search

abap2UI5 / abap2UI5

Developing UI5 Apps Purely in ABAP
http://www.abap2UI5.org
MIT License
284 stars 55 forks source link

Layout Popup #1193

Closed oblomov-dev closed 3 months ago

oblomov-dev commented 3 months ago

continues https://github.com/abap2UI5/abap2UI5/issues/1184 @abapsheep @choper725

Is someone using the old v1 layout with reduced funcitonality or can it be replced by the new one of @abapsheep?

some buttons seem not to work:

image
choper725 commented 3 months ago

im not using it, but removing it is a breaking change.. probebly a new ver. for it will be suitable

oblomov-dev commented 3 months ago

yes good point, will create an obsolete package and then just switch it to this place.

abapsheep commented 3 months ago

Hello, I have made another small change. So the idea was that there are the three options EDIT/OPEN/DELTE. So that the picture is not too restless, all three functions are always shown and only the one that is active is highlighted. For EDIT I added the Okay button which accepts changes but does not save them. I have renamed Back to Close. I hope it is more intuitive now.

oblomov-dev commented 3 months ago

thank you, works now on my end, great work:

image
choper725 commented 3 months ago

@abapsheep once opening select layout popup and hitting Back, the F4 is not opening anymore..

choper725 commented 3 months ago

plus once saving layout and hitting Okay,

column texts seems to dissapear image

image

abapsheep commented 3 months ago

Hello everyone, A brief explanation. image

  1. the "ROW" column shows the technical names of the components. No dictionary texts are displayed here. Could I add this if you want?
  2. the layout has three functions EDIT / SELECT / DELETE. these functions can be called via the three buttons pen, folder and trash can. Depending on the context you are in, the corresponding button is colored blue.
  3. in edit mode there are OKAY and CLOSE (previously BACK). Close exits the popup and the layout is not adjusted. OKAY accepts the changes.
  4. the layout can be saved via Save.

I have not managed to set up the popup with tabs. Unfortunately I have to work with version 1.96.20 and am therefore somewhat limited. Maybe you have an idea how to make the function more user-friendly. I look forward to your feedback :)

About your problem @choper725: When I call up Sample 204 and call F4 and then enter the layout, I can leave the layout via BACK or ESC and end up in the F4 help again. I can then also leave this via ESC or by selecting an entry. I can then call the F4 help again and also the layout. I have not managed to make the texts disappear either...

In Sample 200 I had the problem that when I jump back and forth between the EDIT/SELECT/DELETE functions in the layout, I can no longer get to "on_after_layout" in my calling app. client->get( )-check_on_navigated returns a false here, but I would expect a true. (@oblomov-dev)

oblomov-dev commented 3 months ago

@abapsheep concerning the bug: can not reproduce the error, you just rerender the view but stay in the same popup, thats why no on_navigate is triggered when pressing EDIT/SELECT/DELETE. when you press back, the control flow goes to the previous stack app, which is for some reason also the popup v2 (and not the calling sample app). maybe there is something wrong earlier in the control flow?

choper725 commented 3 months ago

@abapsheep the first error is once i hit back from select layout ir closes both the popup and i cant press the valuehelp on the input anymore until refresh of the entire page

the second one just happen at random, maybe ot got to do somwthing with abap version ? im on 7.5

abapsheep commented 3 months ago

@oblomov-dev I adjusted the App accordingly and now it works. https://github.com/abap2UI5/abap2UI5/pull/1199

abapsheep commented 3 months ago

@choper725 I have been klicking around for 5 minutes, I finaly could reproduce the column texts issue and fixed it.

I cloud not reproduce the navigation Error ... Maybe have another try with the updated Version? When https://github.com/abap2UI5/abap2UI5/pull/1199 is merged.

choper725 commented 3 months ago

sure ill test once merged

oblomov-dev commented 3 months ago

Thank you for the updates @abapsheep merged.

choper725 commented 3 months ago

looks good on my end now..

oblomov-dev commented 3 months ago

everything works also on my end now. to keep the issues small I will close this one. But these layouts are a bigger topic and we could add a lot more stuff, so feel free to open a new issue as soon as we need more functionality.