search

abap2xlsx / abap2xlsx

Generate your professional Excel spreadsheet from ABAP
https://abap2xlsx.github.io/abap2xlsx/
Apache License 2.0
712 stars 291 forks source link

Don't set 'Horizontal Centered' flag in XLSX file. #126

Closed ivanfemia closed 10 years ago

ivanfemia commented 10 years ago

Symptom: flag "Horizontal Centered" set in file only with flag "Vertical Centered". Reason: ZCL_EXCEL_WRITER_2007 method CREATE_XL_SHEET line 1065-1067 repeats 2 times io_worksheet->sheet_setup->vertical_centered. Solution: change one io_worksheet->sheet_setup->vertical_centered to io_worksheet->sheet_setup->horizontal_centered.

ivanfemia commented 10 years ago

Fixed with latest commit [url:https://code.sdn.sap.com/code/abap2xlsx/subversion/changesets/234|#234]

ivanfemia commented 10 years ago

Test report is ZDEMO_EXCEL23.

ivanfemia commented 10 years ago

Sorry, Ivan. Issue not fixed. Please, change IF condition at lines 1070-1072 method CREATE_XL_SHEET class ZCL_EXCEL_WRITER_2007! There are TWO times repeats __io_worksheet->sheet_setup->vertical_centered__. if ONLY horizontal_centered is TRUE (veritcal_centered and print_gridlines are FALSE) condition will be FALSE and attribute 'horizontalCentered' NOT set.

ivanfemia commented 10 years ago

Hi Alexander, have you worked with SubVersion? If yes please check out the current Code from the repository, export your modified ZCL_EXCEL_WRITER_2007, create a patch and attach it to this tread. Also it would be great if you can enhance the Test report to test also the error you've found.

Best regard Gregor

ivanfemia commented 10 years ago
ivanfemia commented 10 years ago

Hi Gregor, i've tried...

ivanfemia commented 10 years ago

(In [[r:249]]) Ready to test #128, thank you Alexander Budeyev the Patch worked.

ivanfemia commented 10 years ago

[[file:cF6vR8dcKr473dacwqjQYw]] Patch