abap2xlsx / abap2xlsx

Generate your professional Excel spreadsheet from ABAP
https://abap2xlsx.github.io/abap2xlsx/
Apache License 2.0
701 stars 288 forks source link

abap2xlsx and PIFs #815

Open creyj opened 2 years ago

creyj commented 2 years ago

Hi all, I installed ABAP2XLSX on a SAP system with development package check “R3ENTERPRISE” . Executing a package check on ABAP2XLSX produces many errors for the sub-packages, as the sub packages cannot access the objects of the super package. Is it possible to create an PIF for ABAP2XLSX? Besides this, there are some other "forbidden" usages like type char7 in ZCL_EXCEL_GRAPH->CREATE_SERIE.

I could solve many package errors by deleting the objects in the DEMO package, but this has to be done after ech . Is it also a possibility to split the demo objects in a second repository?

larshp commented 2 years ago

PINF is supported by abapGit, so it should be possible to create it and push to the repository

CHAR7: also see https://github.com/sapmentors/abap2xlsx/issues/692

creyj commented 2 years ago

I created one and tried to a give use access to the DEMO package. But this did not work ( raised an error ). So a PINF cannot solve the visibility in sub-packages. I assume a reorg of packages is needed. Like a CORE package with DEMOS and NOT_CLOUD package on the same level.

sandraros commented 2 years ago

I don't really know the Package Check feature. I'm not against it, I think it's a good idea to organize objects, as long as people who don't use package check can continue pulling abap2xlsx. I am concerned by the changes to package assignment, not sure if that would imply error messages during pull by abapGit, because the "moved" objects are deleted and created again. If you can fork the project and propose a PR, it will be easier for me/us to evaluate all the impacts. I hope that the Package Check is fully supported by the ABAP trial system 7.52 I use (I guess yes). Thank you for your help. 👍

@larshp @gregorwolf @AndreaBorgia-Abo Could you give your opinion please about introducing package check in abap2xlsx? Thank you! 👍

AndreaBorgia-Abo commented 2 years ago

I have (yet) no opinion about it because my knowledge of this feature is similarly lacking.