Fixes #27 syntax errors (with some gotchas)

abapGit / ADT_Backend

DEPRECATED/NOT WORKING abapGit ADT Backend

MIT License

32 stars 14 forks source link

Fixes #27 syntax errors (with some gotchas) #28

Closed marcellourbani closed 5 years ago

marcellourbani commented 5 years ago

This is NOT a proper fix:

zcl_abapgit_res_repo_pull->post just raises an exception
zcl_abapgit_res_repo_info_ext->post just assumes the repo is private if an user and password is passed

On the plus side all trivial errors (abap_boolean, cl_whatever => zcl_whatever) are fixed it does activate without errors

To fix properly would really help to have access to the version of abapgit this is based upon. Do you know where I can find it?

marcellourbani commented 5 years ago

Not sure it's a good idea fixing all linter issues, as it would drown the actual changes in a myriad of minor ones. At least I would do it in a separate PR