search

abapGit / ADT_Backend

DEPRECATED/NOT WORKING abapGit ADT Backend
MIT License
32 stars 13 forks source link

Push support #44

Closed marcellourbani closed 4 years ago

marcellourbani commented 4 years ago

I got it working adapting the code from SAP. Is it ok to publish and create a PR?

larshp commented 4 years ago

"adapting" ?

marcellourbani commented 4 years ago

Renamed cl* to zcl*, removed references to logging and scheduling classes,... The whole thing was done like that, but if sap does it is fine, I don't have any right on that code. I wouldn't mind coding my own, but to make it compatible I would end up with very similar code anyway, expecially for the transformations

larshp commented 4 years ago

@absap

absap commented 4 years ago

@marcellourbani please feel free to create a PR. I don't know what you mean with "sap does it is fine, I don't have any right on that code". This project is not anyhow associated with, except for using ABAP as language.

marcellourbani commented 4 years ago

@absap What I mean is that I adapted the code from cloud platform: same logic and structure, added a z to abapgit objects, adapted the sap branded abapgit to mainstream one.

The rest of this code looks like it originated the same way, but but I wouldn't post code originated from SAP on a public repository without permission. I didn't even push it on my own repo until I got this answer, and will remove it immediately if there was a misunderstanding

absap commented 4 years ago

Frankly speaking, I would have done it the same way.

I'll be working on a solution that would hopefully suit everyone. Until it's available, it's fine for me to continue this way

larshp commented 4 years ago

cool

@marcellourbani in https://github.com/abapGit/ADT_Backend/tree/lint#requirements it mentions specific version, is this still true? or does it now work with latest?

marcellourbani commented 4 years ago

Not sure, tried a pull on my 750 and failed, although I didn't touch that code (yet) Will have a look later