Generic plugin does not remove TADIR-entry

abapGit / abapGit-Plugins

DEPRECATED - abapGit Plugins Framework

MIT License

17 stars 15 forks source link

Generic plugin does not remove TADIR-entry #8

Closed mrsimpson closed 7 years ago

mrsimpson commented 8 years ago

Create BOPF object
use uninstall option => BOPF object gone, TADIR remains

larshp commented 8 years ago

see similar issue https://github.com/larshp/abapGit/issues/114 and proposed solution

larshp commented 8 years ago

looks like this is actually implemented https://github.com/larshp/abapGit-Plugins/blob/0aa743e2c46b66bbda3d7c14e52318dc06278a63/zcl_abapgit_object_by_sobj.clas.abap#L82

now that https://github.com/larshp/abapGit/issues/114 is closed it is also possible to set delete_tadir in the metadata, and abapGit will handle the deletion

but I guess the current implementation is also okay? @mrsimpson

mrsimpson commented 8 years ago

Even if it was implemented properly (which I doubt), I'd favor to use an option offered by the enclosing framework, if that exists. Need to get my system up and running, so it seems...

larshp commented 8 years ago

fixed, see above commit

larshp commented 7 years ago

fixed, see previous comments, set

rs_metadata-delete_tadir = abap_true.