Closed sbcgua closed 3 years ago
instead of a branch, I suggest creating https://icons.abapgit.org and then a new repo for that homepage, much like the other ones, https://github.com/abapGit?q=abapgit.org&type=&language=&sort=
good idea, so ... could you please create such a repo. And probably add a deployment key for it to this one for ci. I can have a look at the script
created, you should have admin access now in both repos, so you can add deploy keys
@larshp sorry for some delay, wrestling with work, it is a strong opponent :)
I read the https://github.com/peaceiris/actions-gh-pages action attentively - it actually allows deploying to another branch of the same repo (gh-pages in our case). And also specifying cname to that. I think we don't need an extra repo. Let's try this approach. But as I understand the gh-pages must be enabled in the settings - https://github.com/peaceiris/actions-gh-pages#%EF%B8%8F-first-deployment-with-github_token - and I don't have an access there (no admin access ...). Could you pls try enabling it ? I've set the cname to icons2.abapgit.org for now.
P.S. BTW the GITHUB_TOKEN feature seems to be rather unsecure. I changed the workflow in PR and it uses GITHUB_TOKEN ... hmmm ... maybe there is a setting for this ... but don't turn it off yet
All 6 abapGit domains currently use the approach to have a separate repo, here is why:
Notifications happen on the repository level, with a separate repo, users can actively choose to watch the auto generated code being updated or not.
Performance: Having a separate repo keeps the source smaller, in the beginning of using gh-pages in the abapGit repo, the gh-pages branch was actually larger than the source code. We need to optimize for changing the source code
Security: Having one source and one generated repo makes better security when using deploy keys, as only the auto generated repo can be updated. Updating the source repo allows the generation to technically update the source
Administration: Searching allows to quickly get an overview of which domains there are and what they contain, this helps me a lot when having to administer 20+ subdomains across organizations
OK, make sense, agreed. Could you make me an admin of this repo then ? I don't see the settings tab. In the icons.abapgit.org repo I do.
@sbcgua done, try again
also note, github actions is down, since hours ago, https://www.githubstatus.com
Settings: ok, got it. Will continue a bit later today
OK, I guess it works now. Have a look.
Also I adjusted the readme
really nice tooling out there
looks good 🥳 ok to close from my pov
username adjusted in https://github.com/abapGit/icon-font/pull/20
Yeap, thnks ! Closing
ref https://github.com/abapGit/abapGit/pull/4165
npm run build
does create it. Just to find the way to link it into some branch and publish somehow.