search

abapGit / icon-font

icon font
MIT License
1 stars 6 forks source link

Save woff and css with action #11

Closed mbtools closed 3 years ago

mbtools commented 3 years ago

Can we add something like this to test-build.yml (similar to https://github.com/abapGit/abapGit/blob/master/.github/workflows/build.yml)?

    - name: Upload font and css 
      if: always()
      uses: actions/upload-artifact@main
      with:
        name: ag-icons.woff
        path: ./build/ag-icons.woff
        name: ag-icons.css
        path: ./build/ag-icons.css
        retention-days: 7

This way we won't need to setup our own nodejs etc.

PS: Not sure if my syntax is correct.

larshp commented 3 years ago

sure, just create a branch and put the code to the action,

note that this is easy to test, as it will run on pull request

sbcgua commented 3 years ago

Yeah, artifacts would be good idea I would also consider storing the whole artifacts (including HTML) somewhere so, that it is available as this repo page (jekyll?) so that preview of actual icons are available instead of hardcoding them in AG docs. Shuold be easy but I don't have a immediate solution and no time to experiment currently :(