abapGit / icon-font

icon font
MIT License
1 stars 6 forks source link

Create icon git-commit #6

Closed ghost closed 4 years ago

ghost commented 4 years ago

I created this icon myself and publish it hereby under the MIT License. Please note that this icon looks different in browser/editor view than after the build with Node.js 12.13.0.

First I tried to rotate and edit the icon git-commit from https://feathericons.com/?query=commit which is also published under the MIT License (https://github.com/feathericons/feather). But the Node.js build made the icon looks different than in the editor or the browser. I tried to fix that first by editing the icon via Inkscape and then by creating my own one.

Now it looks like this in abapGit, which is fine by me: grafik

Whoever has the power to edit it the way it's meant to be - please do it! :)

larshp commented 4 years ago

thanks, @sbcgua can you help reviewing?

sbcgua commented 4 years ago

@mariusraht2 Good idea with the commit icon. But I'd say it is not quite in line with the rest of the style. E.g. branch has this small whole in the center. Also the icon you created has gaps between the line and the circle. I'd propose to start from branch icon and create the commit one from it to keep same style (something like the 3rd picture below)

image

ghost commented 4 years ago

@sbcgua Yes, I agree with everything you wrote - I'm not very familiar with Inkscape or graphic design at all and the image on the right (3rd one) looks pretty good - could you pull it into this repo instead of my image?

sbcgua commented 4 years ago

done (in master)

smth like this in final version, it's called code-commit

2019-11-19_16h55_16

image

P.S. also built assets just in case... build.zip

ghost commented 4 years ago

Great, many thanks! :)