search

abapinho / abapTimeMachine

ABAP Time Machine provides a much needed way to look at past versions of code in a consistent way. It also provides a sort of git-blame for ABAP (shows the request and author that last modified each line of code).
MIT License
65 stars 12 forks source link

Error when master language <> 'E' #111

Closed abap-weasel closed 2 years ago

abap-weasel commented 3 years ago

abapTimeMachine expects that transport have master language English and raises a general exception (with text "An exception was raised") making it unusable in non-english environments.

Is it possible to remove this restriction?

https://github.com/abapinho/abapTimeMachine/blob/0a6875341fb5e0adfd6140f2677a211b83183460/src/zcl_timem_request.clas.abap#L82-L95

nununo commented 3 years ago

Interesting. I did it this way because I naively thought the English language would always be present. I will try to come up with a workaround. It should not be hard.

desmoloch commented 3 years ago

113

maybe a solution :)

nununo commented 2 years ago

@desmoloch my concern with what you proposed in #113 is that, if an international user logs in with, say, FR while the system's default language is EN or PT or whatever, the SELECT will fail to select any record Or am I wrong?

Looking at E07T, and considering that we are only concerned with workbench, maybe we can ignore the language altogether, even though it is part of the primary key. Because I don't see a scenario in which a workbench will have two entries in E07T for two different languages. Any concerns with this approach?