skip SI_ TABL objects if they are empty

[larshp]

219

@ed-holland can you help testing this change?

[ed-holland]

Sure... will find some time for it today.

[ed-holland]

PR branch code gives this error:

The LV_STRING which is retrieved from the file does not contain a DD02V tag (from si_fkkopr.tabl.xml). <?xml version="1.0" encoding="utf-8"?>#<abapGit version="v1.0.0" serializer="LCL_OBJECT_TABL" serializer_version="v1.0.0"># <asx:abap version="1.0" xmlns:asx="http://www.sap.com/abapxml"/>#</abapGit>

[larshp]

hmm, try setting a breakpoint

[ed-holland]

hmm, try setting a breakpoint

That is how i got the LV_STRING. It did not replace anything so no fields where added.

[larshp]

okay, new plan

https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-us/abenddic_customizing_includes.htm

if SI_, includes are not found, abaplint will continue without errors, https://github.com/abaplint/abaplint/blob/master/packages/core/src/objects/table.ts#L82

[larshp]

try again, logic updated

[ed-holland]

In SCI, the issue is now gone. Thx.

I've noticed two side effects:

1. AbapLint now shows the error (did not before)
2. Local Code shows difference with Remote Code

Is this caused by this PR or by the XML reduction also reducing namespace code?

[larshp]

1: si_fkkopr should not be part of deps anymore, did you update deps? Or perhaps there is a bug in it so it does not delete objects

2: hmm, I doubt its due to the changes in this PR

[ed-holland]

Updated AG/SCI to latest. I've checked it using the deps_list utility and the includes are not generated anymore. After the nightly rebuild of the Deps, they are also gone from the Dependency Repository. All is fine now.

[ed-holland]

Also the local differences are gone.