abaplint / abaplint-sci-server

Node backend application for running abaplint on ABAP
MIT License
20 stars 13 forks source link

message keys/check names #21

Closed larshp closed 4 years ago

larshp commented 4 years ago

https://github.com/abaplint/abaplint-cloud-foundry/issues/13#issuecomment-604509541

we need to improve messages text. All those shortcuts look strange inside sci

@sbcgua

sbcgua commented 4 years ago

sample

image

larshp commented 4 years ago

the data type in SAP is 10 characters, whereas the rule key in abaplint is string

can do a 10 character hash, but not sure it will be better

sbcgua commented 4 years ago

Hmm. But how other messages work ? (I have no idea about SCI internal :(( )

image

larshp commented 4 years ago

hmm, is the column in above screenshot the same as from the first screenshot? cannot tell as its not part of it

sbcgua commented 4 years ago

Yes, it is the lower part. But! I didn't run it via SCI actually.

image

You mean this one has just 10 symbols ?

image

larshp commented 4 years ago

yes, message codes are only 10 characters, data element SCI_ERRC, and its used to group messages of the same type in code inspector = rules in abaplint

the middle screenshot looks like the message description/text, not the message code

larshp commented 4 years ago

see comment in https://github.com/abaplint/abaplint-abap-backend/issues/42

larshp commented 4 years ago

try again, latest version of the abap code

sbcgua commented 4 years ago

will do, but probably need to downport first ... I'll have a look in the coming days

sbcgua commented 4 years ago

hmmmm

image

though debuggin showed that actually it is exception in check->run with Max depth 0 reached for class ZCL_EDE_PARTNER. Exiting dependency walk

larshp commented 4 years ago

double click the line to show the message

mbtools commented 4 years ago

This should work properly now