search

abarichello / godot-ci

Docker image to export Godot Engine games. Templates for Gitlab CI and GitHub Actions to deploy to GitLab Pages/GitHub Pages/Itch.io.
https://hub.docker.com/r/barichello/godot-ci
MIT License
759 stars 133 forks source link

Docker image incorrect godot version argument #139

Open ynot01 opened 6 months ago

ynot01 commented 6 months ago

4.2.2 labels ARG GODOT_VERSION as 4.2.1

mono-4.2.2 labels ARG GODOT_VERSION as 3.4.2

hatmix commented 6 months ago

Not sure if it's related, but the export templates in the 4.2.2 image seem to be missing/broken. 4.2.1 required them to be copied from /root/.local/share/godot/templates/ and this still works for 4.2.1. In 4.2.2 image, the /root/.local/share/godot/templates/ folder does not exist, and the dockerfile seems to put them into the correct folder, but exports still fail.

Calinou commented 6 months ago

The folder in Godot 4 is named export_templates instead of templates, so please update your CI files accordingly:

https://github.com/abarichello/godot-ci/blob/66b7d6fef1760939f04c21a589cf1aa99855849d/.github/workflows/godot-ci.yml#L22-L23