search

abarichello / godot-ci

Docker image to export Godot Engine games. Templates for Gitlab CI and GitHub Actions to deploy to GitLab Pages/GitHub Pages/Itch.io.
https://hub.docker.com/r/barichello/godot-ci
MIT License
758 stars 133 forks source link

GitHub Actions workflow is unable to start rcedit #148

Open OverloadedOrama opened 3 months ago

OverloadedOrama commented 3 months ago

I'm getting this error when using godot-ci (Godot 4.3) to export a Windows build: WARNING: Resources Modification: Could not start rcedit executable. Configure rcedit path in the Editor Settings (Export > Windows > rcedit), or disable "Application > Modify Resources" in the export preset. Example run, on the Windows build step: https://github.com/Orama-Interactive/Pixelorama/actions/runs/10490990141/job/29058991598

Not sure if I need to setup anything myself extra, but because #146 is now merged, I am assuming I don't have to.

Kiisu-Master commented 3 months ago

~/.config/godot/editor_settings-4.tres is now ~/.config/godot/editor_settings-4.3.tres and will change with every feature or major release.

Kiisu-Master commented 3 months ago

This probably also breaks the android part of the stuff.

I already dealt with this change on GodSVG exports ( custom github actions instead of this image ). I decided to just add a new argument for the Godot feature version, because I didn't want to try extracting the feature version from the full version. I don't know how this Docker stuff works and if it's possible to do the same here...

Calinou commented 3 months ago

I'm puzzled that 4.3-stable was tagged when the files within its tag still refer to 4.2.1.

OverloadedOrama commented 3 months ago

I'm puzzled that 4.3-stable was tagged when the files within its tag still refer to 4.2.1.

That's because the release.yml workflow is updating the GODOT_VERSION argument