search

abarichello / godot-ci

Docker image to export Godot Engine games. Templates for Gitlab CI and GitHub Actions to deploy to GitLab Pages/GitHub Pages/Itch.io.
https://hub.docker.com/r/barichello/godot-ci
MIT License
758 stars 133 forks source link

Update for Godot 4.3 #149

Closed Calinou closed 1 month ago

Calinou commented 3 months ago

editor_settings.tres is now split per minor version since 4.3.

This also updates mono.Dockerfile to match the main Dockerfile.

OverloadedOrama commented 3 months ago

The release.yml workflow also needs to change so that it updates the GODOT_VERSION_MAJOR_MINOR argument, like it does for GODOT_VERSION

Kiisu-Master commented 3 months ago

Ooh what is that?!?!

Kiisu-Master commented 3 months ago

If this is like regex then we have to check if the version string is always the full one like "4.3.0", because if its "4.3" i imagine it would break.

Kiisu-Master commented 3 months ago

If im understand this correctly: https://github.com/abarichello/godot-ci/blob/bd9eea16d14bf71f5876b71b16955218df36266b/.github/workflows/release.yml#L17-L19 it's extracting the version string from this repos tags, which don't have the x.y.z format for every release.

Calinou commented 3 months ago

I've reworked the script to not require a new GODOT_MAJOR_MINOR_VERSION variable (thanks to Bash variable substitution).

However, since Godot does not use .0 for the first patch release, this means 4.3 would be trimmed into 4. Perhaps using something to always trim the string to 3 characters would be better, although it'll break if we ever reach 4.10.

RealrealChaiR commented 3 months ago

Do we want to update the mono image's version ARG while were here? I get the release.yml overrides it but it looks like we're trying to clean up across the board.

https://github.com/abarichello/godot-ci/pull/149/files#diff-d79da252bb700d7827e34d08ba8526c6a57642e0e0170d22580eddb090fd418eL22

Calinou commented 3 months ago

Do we want to update the mono image's version ARG while were here? I get the release.yml overrides it but it looks like we're trying to clean up across the board.

#149 (files)

Done. The Mono Dockerfile now matches the main one more or less, with support for exporting to Android and using rcedit for Windows exports. I haven't tested it though.