search

abarichello / godot-ci

Docker image to export Godot Engine games. Templates for Gitlab CI and GitHub Actions to deploy to GitLab Pages/GitHub Pages/Itch.io.
https://hub.docker.com/r/barichello/godot-ci
MIT License
758 stars 133 forks source link

Fix godot editor settings and java path #154

Closed NetSysFire closed 1 month ago

NetSysFire commented 2 months ago

Fixes #151.

What I found out:

  1. ✅ Godot is content with no newline between the two lines that get added to the editor settings even though my local file has one.
  2. ✅ The Java path is static and will work as is.
  3. ❌ I am using Godot 4.3 in the workflows in my repo. It requires the file to be editor_settings-4.3.tres and not editor_settings-4.tres. I do not see a way to derive config file name from the existing GODOT_VERSION variable without hardcoding it.
  4. ✅ ~ resolves to /root in the Dockerfile. When using this container in a github workflow, ~ resolves to /github/home and Godot will try to read the config from there. So I updated the workflow to move the godot config dir just like the export templates.
NetSysFire commented 2 months ago

I just noticed that #149 will probably handle the third point, which is great.

Calinou commented 1 month ago

@NetSysFire I've just merged https://github.com/abarichello/godot-ci/pull/149. Could you look into rebasing on top of master to fix merge conflicts?

NetSysFire commented 1 month ago

@Calinou Rebased and also applied the changes to the mono.Dockerfile.

Given https://github.com/abarichello/godot-ci/issues/151#issuecomment-2370740746, I also changed the code to overwrite the file instead of appending with the first directive. I still do not know how the commenter started with a good file but this just makes sure we are starting with a blank config file and are not inserting these headers into an existing config file, making it invalid and breaking stuff.