abarichello / godot-ci

Docker image to export Godot Engine games. Templates for Gitlab CI and GitHub Actions to deploy to GitLab Pages/GitHub Pages/Itch.io.
https://hub.docker.com/r/barichello/godot-ci
MIT License
758 stars 133 forks source link

Remove needless cd from gitlab-ci. #56

Closed rcorre closed 3 years ago

rcorre commented 3 years ago

It seems that the workdir for gitlab is already inside the cloned repo, so cd $EXPORT_NAME will fail.

Here's a build that prints pwd to demonstrate: https://gitlab.com/rcorre/weekly-game-jam-204/-/jobs/1318895344

Here's a pipeline that passed after removing cd:

abarichello commented 3 years ago

The cd is there because this repo includes an example project in another folder to organize between examples and godot-ci specific files, removing that will cause all my pipelines to fail. I know that godot projects are not usually included in a folder but doing this here would be confusing. Since the gitlab-ci.yml is a template for people to modify according to their needs I suggest you keep the cd command there and add a comment instructing people to remove it if their project root is not included in a folder

abarichello commented 3 years ago

Thanks!